-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Docker Build Cloud #1354
Conversation
@alexohre Can you try this PR out for your cloud build? |
821ba25
to
4530a0a
Compare
I believe the build failure is an intermittent failure and should pass if the GitHub Actions were re-ran. I don't see a way to do that myself. |
@matthewbjones Can we create the build setup automatically? That'll keep it closer in functionality to the remote builder. We'd just need https://github.com/basecamp/kamal/blob/main/lib/kamal/commands/builder/remote.rb#L56 |
4530a0a
to
3c47f64
Compare
Thanks for the suggestion, I've updated the PR to add this functionality. |
Thanks for the update @nickhammond, That's exactly what I've been waiting for all this while. |
@alexohre All credit goes to @matthewbjones! 🙌 |
@nickhammond definitely, a big thanks to @matthewbjones for his exceptional contribution 👏 |
Looks great @matthewbjones. Just one suggestion and we can get that merged. |
3c47f64
to
b420b26
Compare
@djmb Thanks for the code review and suggestion, I've updated the PR as requested |
@djmb all tests passed locally, and passed previously, the slight code update shouldn't have caused test failures. I don't see a way on my end to have GitHub Actions re-run, are you able to do that on your end? |
@matthewbjones - I think you just caught some broken tests on main. They are fixed now and I've merged in main, so hopefully that will fix them |
@djmb Makes sense, thanks! Looks like they all pass now :-) |
I thought this branch had been merged with the main. I added |
@alexohre It has but a release hasn't been cut yet. You can point your Gemfile at this repo and then prefix your kamal commands with |
thanks @nickhammond, it's working now. |
This PR aims to add the minimal amount of code changes to support building using Docker Build Cloud
Although Kamal already currently supports remote builds using
remote: ssh://user@ip-address
, some individuals or organizations may prefer to use Docker Build Cloud for remote compiling (for example, you don't have a remote machine around to utilize remote builds)Assuming you're using Docker Build Cloud, and you've already created a builder on your Docker Build Cloud, then, all you need to do with Kamal is specify the driver:
When specifying
driver: cloud ...
, thebuildx
commands will now pass in a--builder cloud-org-name-builder-name
to instructbuildx
to use that builder. It will also automatically register and remove the cloud driver as well.Related Discussion: #914