Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ssh: use secret in key_data #1425

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

idrista
Copy link

@idrista idrista commented Feb 22, 2025

Support secret lookup for key_data

What’s changed?

  • key_data can now be a string to reference a secret, just like registry.username and registry.password.
  • To avoid breaking changes, the behavior is reversed compared to registry:
    • Registry.username | Registry.password : Array → lookup secret, String → raw value
    • SSH.key_data: Array → raw value, String → lookup secret

Why?

  • This makes it easier to manage SSH keys securely using .kamal/secrets.
  • Avoids exposing sensitive data in Git.

@idrista idrista marked this pull request as draft February 22, 2025 22:29
@idrista idrista marked this pull request as ready for review February 22, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant