Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaffeinate #157

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Decaffeinate #157

wants to merge 4 commits into from

Conversation

brunoprietog
Copy link

I'm proposing to remove CofeeScript and convert it to JavaScript, just like Trix.

In some situations I was quite conservative in adopting a more JavaScript style in the code out of insecurities if it would cause the same effect.

This should help make contributing more enjoyable!

@brunoprietog brunoprietog changed the title Rename files from .coffee to .js and convert to JavaScript Decaffeinate Dec 6, 2023
@josefarias
Copy link
Contributor

josefarias commented Jan 4, 2024

Sorry about the radio silence here @brunoprietog. We're very aware of this PR and it's definitely something we want to merge. Thanks for putting it together.

We have competing priorities right now and can only justify spending a few days at a time on this library. So I'm a bit torn between thoroughly reviewing this conversion and implementing some quick features we need in our products (features that would have to be ported into this PR before merging, which I'm happy to help with).

As things are, I think the best way forward is to implement those (small) features and bug fixes so we can cut a new release. And once that's done we can take the time to walk through this, since it touches practically every file in the library.

In the meantime, have you considered re-implementing the JS to remove the use of the __guard__ functions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants