This repository was archived by the owner on May 15, 2020. It is now read-only.
Change listen() in DnsServer to use socket creation callback interface. #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per reference in [10.26 UDP docs](http://nodejs.org/api/dgram.html#dgram_udp_datagram_sockets): > Important note: the behavior of dgram.Socket#bind() has changed in v0.10 and is always asynchronous now. The listen interface calls bind() on the underlying dns_server/Socket, and immediately invokes its own callback if provided. This has been changed to call it from inside the callback arg in the new `bind(port, [adr], [cb])` format, which fixes test breakage in `test_dns_server.coffee` due to trying to call `address` too soon.
|
I notice the travis build fails when tested against node 0.8, which you'd expect since the dgram bind API changed (which if I'm reading it rightly, was back in 0.9.1+, commit 332fea5ac1816e. Does 0.8 support actually matter? I have no idea how you'd conditionally callback or not |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per reference in
10.26 UDP docs:
The listen interface calls bind() on the underlying dns_server/Socket, and immediately invokes its own callback if provided. This has been changed to call it from inside the callback arg in the new
bind(port, [adr], [cb])format, which fixes test breakage intest_dns_server.coffeedue to trying to calladdresstoo soon.