Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce yarn build --watch #1216

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Reintroduce yarn build --watch #1216

merged 2 commits into from
Dec 17, 2024

Conversation

intrip
Copy link
Member

@intrip intrip commented Dec 17, 2024

  • Switch from node-sass to sass #1215 indirectly removed the --watch mode, by switching SCSS compilation
    to a node.js file. This was required because the sass CLI doesn't support the --function option for custom JS functions.
    Now reintroduce it back using chokidar. This also fixes yarn start command.
  • Additionally, switch to compile method. No changes to the CSS generated.

Use `compile` instead the deprecated `render` method.
No changes to the generated `.css`.

See https://sass-lang.com/documentation/js-api/functions/render/
#1215 indirectly removed the `--watch` mode, by switching SCSS compilation
to a node.js file. This was required because the `sass` CLI doesn't support the `--function` for custom functions.
Now reintroduce it back using `chokidar`. This also fixes `yarn start` command.
Copy link
Member

@jorgemanrubia jorgemanrubia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing @intrip!

@jorgemanrubia jorgemanrubia merged commit 4f279fd into main Dec 17, 2024
3 checks passed
@jorgemanrubia jorgemanrubia deleted the fix-yarn-start branch December 17, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants