Selection #2
Merged
Selection #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lovely! |
|
|
||
| range = document.createRange() | ||
| start = [startContainer, startOffset] = @findContainerAndOffsetForPosition(startPosition) | ||
| end = [endContainer, endOffset] = @findContainerAndOffsetForPosition(endPosition) |
There was a problem hiding this comment.
Doesn't look like start and end are used.
There was a problem hiding this comment.
Whoops! Logging remnants.
|
I closed #1. Merge away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I renamed RichText.Renderer to RichText.DOM and implemented getSelectedRange and setSelectedRange methods there, since rendering and selection mapping are intimately related.
RichText.Controller has getPosition and getSelectedRange methods which delegate to RichText.DOM; the former returns a position if and only if the selection is collapsed, and the latter returns a range if and only if the selection is not collapsed.
The insertText and backspace methods now do the right thing depending on whether or not there's a selection.