Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel pipeline. Doesn't work for request canlleations yet #354

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marius-baseten
Copy link
Contributor

No description provided.

self._exception = e
return

async def predict(self, model_input, request: fastapi.Request):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can keep this sync, and use something like this to check for disconnection. ie:

from anyio import from_thread
def predict(self, model_input, request: fastapi.Request):
     is_disconnected = from_thread.run(request.is_disconnected)
     if is_disconnected:
         raise HTTPException(...)    

cancelling the ongoing inference is tricky though

@marius-baseten marius-baseten marked this pull request as draft November 11, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants