text-embeddings-inference updated example trussless #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfeil
changed the title
vshulman
requested changes
Dec 17, 2024
| @@ -0,0 +1,28 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Not sure, that's why I left it in. Do we want to keep this?
text-embeddings-inference/custom_server/.maintain/roll_out_docker.sh
Outdated
Show resolved
Hide resolved
|
Okay, worked on it! @vshulman |
vshulman
reviewed
Dec 20, 2024
internal/config.yaml
Outdated
| - which model is deployed | ||
| - how many concurrent requests users are sending | ||
|
|
||
| The deployment example is for Bert-large and a Nvidia-L4. Bert-large has a maxiumum sequence length of 512 tokens per sentence. |
text-embeddings-inference/README.md
Outdated
| --max-client-batch-size 256 | ||
| ``` | ||
| This determines the number of sentences / items in a single request. | ||
| For optimal autoscaling that gets regulated by metrics such as requests/second in Baseten's infrastructure, you want to set this as low as possible. OpenAI-API historically set it to `--max-client-batch-size 32`, which could help for more aggressive autoscaling and thus better latency. One the other hand, frameworks such as LLamaIndex, Langchain or Haystack might prefer or even require higher batch_sizes, especially if the user code is old-fashioned and sends requests 1-by-1 in a for loop. This depends on your users & how you are planning to use your deployment. |
There was a problem hiding this comment.
this is a little hard to follow
There was a problem hiding this comment.
updated it, and just set it 32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a trusses example for text-embeddings-inference