Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing empty lines and leading/trailing trivias #14

Closed
wants to merge 1 commit into from

Conversation

csillikd
Copy link

-Empty lines are recognized as leading or trailing trivia
-Every node can have leading/trailing trivia

Notice: IsBlank is still a valid function, an only-whitespace document contains a single "blank" UnrecognizedNode.

@bash
Copy link
Owner

bash commented Jun 17, 2024

Thanks for putting work into this! I will try to review/merge/release this sometime this week but no promises ;)

@bash bash linked an issue Jun 17, 2024 that may be closed by this pull request
@bash
Copy link
Owner

bash commented Jun 17, 2024

I started reviewing your PR today and added some tests for your new code (some WIP stuff is here if you're interested)
...and I promptly found a bug (#15) in my tokenizer 😄

Enough for today :)

@csillikd csillikd closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty lines are recognized as an UnrecognizedIniNode
3 participants