Fix rpc calls via nodetool #1107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2022 13:45
…rcedes nodetool, we have to force the use of nodetool as erl_call does not have support for catching stdio (not implemented in relx). Nodetool also changed rpc calls slightly by requiring args as a list, and changed the expected return from rpc calls, anything other than rpc_ok gets printed to the shell now :/
…dmin rel version back to the rel/files/riak-admin file, doh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relx 4.5+ makes use of erl_call, which supersedes nodetool, we have to force the use of nodetool as erl_call does not have support for catching stdio (not implemented in relx). This is done via the use of the USE_NODETOOL=1 flag in the run_rpc function.
Without any changes, calling console commands via the usual
relx_nodetool rpcmethod:Nodetool also changed rpc calls slightly by requiring args as a comma separated list, and changed the expected return from rpc calls, anything other than rpc_ok gets printed to the shell now :/ (it doesn't with this fix).
This was before (trailing ok is printed out from every command:
Fixed, by using a proxy function (to swallow the ok, and return rpc_ok instead) in a separate PR in riak_kv:
