Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update riak-admin escape to use printf instead of echo #1134

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

aef-
Copy link

@aef- aef- commented Apr 14, 2023

echo is not the most portable method to pipe output. In some systems echo -n hello will output "-n hello". I was experiencing this when getting an "invalid JSON" error while creating buckets with riak admin. printf is a more reliable way to "echo" variables without newlines.

… `echo -n hello` will output `"-n hello"`. `printf` is a more reliable way to "echo" variables without newlines.
@martinsumner martinsumner self-requested a review April 19, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants