-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue to adapt color temperature down to the sleep temperature after sunset #87
Conversation
Continue to adapt color temperature down to the sleep temperature after sunset. Results in a gradually warming light during the night time rather than a fixed color temperature throughout the night time.
This looks good! Have you been testing this at home yourself for sometime? |
Yeap I’ve got it setup in my house across 4 zones and works like a charm. Try it out, I’ve set a 4500k max temp, 3000k minimum colour temp and a 2000 sleep temp. See below graph. The blips are due to me switching on and off the adaptive light switch. |
Have been using your integration for a few months now, this looks like a very useful addition. @basnijholt do you think you will merge this into next release? |
Unfortunately, I haven't had the time to test it myself yet. I know many people will blindly smash the update button in HACS so I am a bit careful with changing the core logic. |
I understand, your point is very valid. Just want to say thanks again, been running your integration for the last few months and it is already amazing in its current form. Looking forward where you will take it in the future. |
Thought to comment back- been using it and has been flawlessly since the beginning of Feb. |
I really like this idea, a lot. Adaptive Lighting makes everything so smooth you never notice the lighting changes - it's just always perfect. Except when transitioning to sleep mode, which if it's a big change, can be jarring. Some food for thought: My point is - the functionality in the PR seems like it kind of assumes the sleep color temp is lower (on the kelvin scale) than the min color temp, and that's not how all users use the sleep settings. |
Good idea! I stumbled on this effect when about a year ago I replaced my bulbs in the bathrooms with 6500K bulbs. I was worried about how harsh that color temp would appear at night. I reset the (non-smart) dimmers to dim very low. I noticed at night when I turned on the light in the bathroom to the minimum brightness, it gave a very pleasant moonlight effect. |
Any update on when this might be merged and released? Thanks! |
6974e9c
to
c05e0cc
Compare
for more information, see https://pre-commit.ci
@basnijholt Hey this PR automerged. It was supposed to wait for all reviewers to approve it and the tests to pass. I'm so sorry. It's absolutely done though, the config option is the only thing that activates it and it defaults to false. |
I already wondered how this suddenly got in. Thanks for explaining and thanks for getting this over the finish line! |
@all-contributors please add @igiannakas for code |
I've put up a pull request to add @igiannakas! 🎉 |
I just released https://github.com/basnijholt/adaptive-lighting/releases/tag/1.9.0, thanks @igiannakas! |
Thank you for the mention 😀 |
Continue to adapt color temperature down to the sleep temperature after sunset. Results in a gradually warming light during the night time rather than a fixed color temperature throughout the night time.