Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed v2.0.2 rewrite using [email protected] #31

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

johnbeech
Copy link

@johnbeech johnbeech commented Feb 20, 2021

I've raised an issue here: #32 to advertise an updated version of the tool as a potential candidate to merge in the future.

Proposed change log:

2.0.2

Changes

  • Add guard for parsing worksheets that don't contain cells; i.e. charts

2.0.1

Changes

  • Fix bug with allWorksheets: true and added additional test

2.0.0

New

  • Tests and CI using Github Actions to repo

Changes

  • Fixed security vulnerabilities reported by npm audit
  • Updated google-spreadsheet depenedncy
  • Removed support for public published sheets due to deprecated authentication options
  • Examples now use async await
  • Changed internal workings to use 0 based indexes for rows and columns
  • Changed internal workings to use cleaner async await code
  • Introduced standard js as the enforced linter as part of the CI actions

johnbeech and others added 18 commits February 20, 2021 09:47
Maintenance: Create PR Check Workflow from Template
* Add end-to-end test for an actual spreadsheet
* Rewrite of helper.js to use new google-spreadsheet module API
* Implement correct search behaviour for mapping data
* Fix test to work on CI environment
* Remove work in progress console.log
* Update README and CHANGELOG
* Add note about fixed security vulnerabilities
* Add test-example.js to check equivalent code in README
@johnbeech johnbeech changed the title Proposed v2.0.0 rewrite using [email protected] Proposed v2.0.1 rewrite using [email protected] Feb 21, 2021
@johnbeech johnbeech changed the title Proposed v2.0.1 rewrite using [email protected] Proposed v2.0.2 rewrite using [email protected] Feb 21, 2021
@spatical
Copy link

@bassarisse I tested this updated code from @johnbeech and it seems to work great. In fact for my basic usage I was able to simply load his updated version without any code changes to my actual implementation code. I'd definitely recommend this update since the Google Spreadsheet module that is referenced has now passed the date that it was said to have been deprecated.

@gamedevsam
Copy link

Any reason why this shouldn't be merged? This library is kinda useless without these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants