-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed v2.0.2 rewrite using [email protected] #31
base: master
Are you sure you want to change the base?
Conversation
Maintenance: Create PR Check Workflow from Template
Software: npm package-lock rebuild
* Add end-to-end test for an actual spreadsheet * Rewrite of helper.js to use new google-spreadsheet module API * Implement correct search behaviour for mapping data * Fix test to work on CI environment * Remove work in progress console.log * Update README and CHANGELOG * Add note about fixed security vulnerabilities * Add test-example.js to check equivalent code in README
@bassarisse I tested this updated code from @johnbeech and it seems to work great. In fact for my basic usage I was able to simply load his updated version without any code changes to my actual implementation code. I'd definitely recommend this update since the Google Spreadsheet module that is referenced has now passed the date that it was said to have been deprecated. |
Any reason why this shouldn't be merged? This library is kinda useless without these changes. |
I've raised an issue here: #32 to advertise an updated version of the tool as a potential candidate to merge in the future.
Proposed change log:
2.0.2
Changes
2.0.1
Changes
allWorksheets: true
and added additional test2.0.0
New
Changes
npm audit