Implement CellRntiRingBuffer and fix sending delay #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add RingBuffer to count most frequent RNTIs over mutliple iterations * Move mathematic utilitites from util to new module math_util * Add MatchingErrorHandling -> Reset traffic generator on matching error -> Make math functions return Result<> Debug CPU usage of rntimatcher.gen thread: In the traffic_generator thread, the TrafficPattern was in every sending iteration (a) cloned and (b) wrapped into a new Box instance which lead to high frequent memory allocation. This induced a high delay on the traffic pattern sending and high CPU usage of ~80% for the traffic_generator thread. With this fix, the sending rate for pattern A increased from ~800 Kbit/s to ~12 Mbit/s!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug CPU usage of rntimatcher.gen thread:
In the traffic_generator thread, the TrafficPattern was in every sending iteration (a) cloned and (b) wrapped into a new Box instance which lead to high frequent memory allocation. This induced a high delay on the traffic pattern sending and high CPU usage of ~80% for the traffic_generator thread. With this fix, the sending rate for pattern A increased from ~800 Kbit/s to ~12 Mbit/s!!!