Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SUBFOLDER as asset base to allow mounting homer at a different base path. #694

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ignatz
Copy link

@ignatz ignatz commented Aug 30, 2023

To try run e.g.:

$ docker build -t homer --build-arg SUBFOLDER=/bar . && docker run --rm -p 8080:8080 -e SUBFOLDER=/bar homer

before and after. Previously, the base path wasn't set. So when browsing to the lighthttp alias, you'd be instantly be sent back to the root path.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #578

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've read & comply with the contributing guidelines
  • I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • I have made corresponding changes to the documentation (README.md).
  • I've checked my modifications for any breaking changes, especially in the config.yml file

…base-path. This allows mounting homer at a different base path, e.g when using a reverse proxy. Addresses issue/578.
@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for homer-demo-content ready!

Name Link
🔨 Latest commit 9fcaedf
🔍 Latest deploy log https://app.netlify.com/sites/homer-demo-content/deploys/64ef9aebfddcdf00087161d0
😎 Deploy Preview https://deploy-preview-694--homer-demo-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ignatz
Copy link
Author

ignatz commented Aug 30, 2023

Note that a downside of this relatively straight forward approach is that users will have to build their own docker package with the build_arg set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hosting homer behind reverse proxy on subpath
1 participant