Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaps #147

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Gaps #147

wants to merge 4 commits into from

Commits on Feb 14, 2013

  1. New shuffle method using gaps

    bauerca committed Feb 14, 2013
    Configuration menu
    Copy the full SHA
    4e1d2d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2013

  1. Change from item wrapper to gaps layout technique

    Remove DragSortListItem class and accompanying method
    for creating gaps between list items. A summary:
    
    Prior to this commit, each list item was wrapped in a
    lightweight ViewGroup called DragSortListItem. DSLV
    would modify the height of the wrapper (leaving the
    height of the wrapped layout unchanged) to create blank
    spaces between list items so as to indicate the new
    position into which the dragged item might be dropped.
    
    The new behavior does away with the DragSortListItem
    wrapper and, instead, shifts the list items away from
    each other to create the drop/shuffle gaps.
    A few advantages over the old method come to mind:
    
    - Removes unnecessary added layer in the View hierarchy.
    - Item shuffling avoids layout passes (unless scrolling),
    simply calling `invalidate()`.
    - Code is more elegant and maintainable (previous hacks
    to improve shuffling and scrolling smoothness magically
    disappear).
    bauerca committed Feb 19, 2013
    Configuration menu
    Copy the full SHA
    1304d47 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2013

  1. Generalize gap technique

    Replace bitmask for customizing each Gap with a
    simple minimum height parameter. Bitmask was overkill,
    adding unnecessary complication.
    bauerca committed Feb 28, 2013
    Configuration menu
    Copy the full SHA
    80a3c62 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2014

  1. Compilation fixes.

    bauerca committed Sep 24, 2014
    Configuration menu
    Copy the full SHA
    e22d0d4 View commit details
    Browse the repository at this point in the history