Check inside_interval_mask before computing splines #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the (rare) event that there are no points inside the spline interval, computing a spline crashes because it assumes implicitly that the interval contains points (e.g. via use of `min()`). This patch fixes this behaviour.
|
Nice and simple, thank you! For this to be complete, any chance simple test cases could be added for affected functions? Should be as simple passing in inputs that are all outside of the spline interval, and making sure the outputs make sense (see https://github.com/bayesiains/nsf/blob/master/nde/transforms/splines/linear_test.py and other *_test.py files in the same folder). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the (rare) event that there are no points inside the spline interval,
computing a spline crashes because it assumes implicitly that the
interval contains points (e.g. via use of
min()). This patch fixesthis behaviour.