merge upstream develop #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.6 to 4.1.7. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@a5ac7e5...692973e) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…/checkout-4.1.7 Bump actions/checkout from 4.1.6 to 4.1.7
closes #389
Before this commit, Edirom Online assumed that an annotation would only be shown if it matched both category and priority filters; this was a problem for editions that would not use, e.g., priorities at all. Consequently, the priorities filter would be empty, and the annotation would always return false for that filter. After this commit, there is a value 'undefined' for visibleCategorie and visibleAnnotations, and the filter corresponding result for an annotation will be set to true if the corresponding visibleCategorie or visiblePriorities is 'undefined',
Merge pull request #390 from Edirom/fix/getAnnotationOverlay
…element retrieval maybe fix later
…bleCategories variable
…e menu would be populated
Signed-off-by: Benjamin W. Bohl <[email protected]>
this commit introduces a PR template. Refs #406
information regarding how to test the code before starting a pull request was added, the description was taken from the README.md. Refs #408
thanks @riedde for reviewing. i like your updates :) Co-authored-by: Dennis Ried <[email protected]>
this commit adds a lot of information to this file, eg mission statement and project examples. the small description part how to test was moved to CONTRIBUTING, since the whole description of contribution is living in this file. the paragraph "Starting an Edirom instance locally" was written by @daniel-jettka, thanks to this great improvement to help others to get their edirom started with this guidance! ... images will be added quite soon Refs #399
this commit adds 3 screenshots to support getting an impression of the described showcases
this commit reacts to a review remark by @peterstadler by translating a work to english and delete some links that are already included in the introduction ti improve the reading flow. thanks for improving the text with your review, Peter :) Refs #399
thanks @peterstadler for your review. i accept all of your ideas! Co-authored-by: Peter Stadler <[email protected]>
Co-authored-by: Peter Stadler <[email protected]>
thanks for your patience! Co-authored-by: Peter Stadler <[email protected]>
[Ftr] update readme
[ftr] Set up CONTRIBUTING.md Thank you.
add code of conduct
Create pull_request_template.md
Ftr/358 grayout goto movement
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.4.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b2256b...5076954) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Salome and I were testing the current build artifact and realized that the TEI Stylesheets were missing in the EOL xar which caused the Edirom to fail miserably. Introducing `submodules: 'recursive'` will hopefully fix this – or is there any reason to exclude the submodules from the build here?
checkout repository recursively in Github action
…erialize-options-with-output-options replace proprietary `exist:serialize` options
…/upload-artifact-4.4.0 Bump actions/upload-artifact from 4.3.4 to 4.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.