Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csat pd 254370 bv fetch cache issue #143

Open
wants to merge 4 commits into
base: master-csat-pd-254370-bv-fetch-cache
Choose a base branch
from
Open

Csat pd 254370 bv fetch cache issue #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb0e381
[PD-254370] : bv-fetch catch clear issue resolved
visheshsanghani Sep 18, 2024
642c6c5
Release 2.9.4
visheshsanghani Sep 20, 2024
7504784
[PD-254370]: BV Fetch cache issue resolved
visheshsanghani Sep 25, 2024
761e629
Release 2.9.5
visheshsanghani Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/bvFetch/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

/**
* @fileOverview
* Provides api response caching utilties
Expand Down Expand Up @@ -133,7 +132,10 @@ module.exports = function BvFetch ({ shouldCache, cacheName, cacheLimit }) {
.then((cache) => {
return cache.match(cacheKey)
.then((cachedResponse) => {

if (!cachedResponse) {
this.cachedUrls.delete(cacheKey)
return Promise.resolve(null);
}
const cachedTime = cachedResponse.headers.get('X-Bazaarvoice-Cached-Time');
const ttl = cachedResponse.headers.get('Cache-Control').match(/max-age=(\d+)/)[1];
const currentTimestamp = Date.now();
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "bv-ui-core",
"version": "2.9.3",
"version": "2.9.5",
"license": "Apache 2.0",
"description": "Bazaarvoice UI-related JavaScript",
"repository": {
Expand Down