Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: create an interface to allow for convention checking in gazelle #1900

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tyler-french
Copy link
Contributor

@tyler-french tyler-french commented Aug 28, 2024

Currently, at Uber, we do not use an index. Instead, we use conventions and a set of # gazelle:resolve statements in the root BUILD.bazel file.

This is beneficial because it means we can run Gazelle O(size change) instead of `O(size repo)'

This can be enabled by running bazel run //:gazelle -- --use_conventions with flag

Fixes #1907

@tyler-french tyler-french force-pushed the convention branch 9 times, most recently from 1786849 to 9393b3c Compare August 28, 2024 21:39
@tyler-french
Copy link
Contributor Author

@fmeum @linzhp still a draft, but let me know if you have any preliminary thoughts. Especially on how to make it more ubiquitous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Add optional gazelle ConventionChecker interface to avoid indexing.
1 participant