windows tar toolchain gzip errors

[jbedard]

See https://github.com/aspect-build/rules_js/actions/runs/11391002935/job/31694034057?pr=1989#step:7:456

(18:41:49) ERROR: D:/a/rules_js/rules_js/e2e/bzlmod/BUILD.bazel:14:22: Extracting npm package [email protected] failed: (Exit 1): tar.exe failed: error executing command (from target //:.aspect_rules_js/node_modules/[email protected]/pkg) external\aspect_bazel_lib~2.9.0~toolchains~bsd_tar_windows_amd64\tar.exe --extract --no-same-owner --no-same-permissions --strip-components 1 --file ... (remaining 3 arguments skipped)
tar.exe: Error opening archive: Can't initialize filter; unable to run program "gzip -d"

[thesayyn]

Turns out we don't link any of the [de]compression filters for windows builds, they were simply shelling out to system binaries, which did not exist in this case.

This is where we set these for mac and linux

https://github.com/bazelbuild/bazel-central-registry/blob/ef34e6bfad5a6ab54080ddcc83a4d65849855e3a/modules/libarchive/3.7.5/patches/build_with_bazel.patch#L1510-L1522

but not for windows

https://github.com/bazelbuild/bazel-central-registry/blob/ef34e6bfad5a6ab54080ddcc83a4d65849855e3a/modules/libarchive/3.7.5/patches/build_with_bazel.patch#L1548

[thesayyn]

Needs to be fixed in libarchive in BCR before it can be fixed here.

[thesayyn]

Related #848

[thesayyn]

@jbedard bazelbuild/bazel-central-registry#3225 is going to fix this but there #952 that needs to be fixed before we can roll this

[devversion]

Is there any way we can help to unblock this? this prevents adoption of rules_js on our end as we run Windows jobs

[thesayyn]

@devversion i have fixed this upstream BCR already. I just need to go around and cut some releases to have the fix in prebuilt toolchains.

[devversion]

@thesayyn thanks for doing that! isn't #952 still a blocker?

[thesayyn]

Potentially, unfortunately there is no clear repro for me to confirm so it requires some digging to repro and make sure it's fixed.