Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openssl as a dependency for cmake when building cmake from source #803

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jsharpe
Copy link
Member

@jsharpe jsharpe commented Oct 20, 2021

Update cmake build to include openssl as a dependency.

Closes #709.

@jsharpe
Copy link
Member Author

jsharpe commented Oct 20, 2021

@UebelAndre the only issue with this change is that because openssl requires rules_perl then this means we'd need to move to a two phase initialisation in the WORKSPACE to be able to call the rules_perl setup functions unless you can think of a way to avoid this?

@UebelAndre
Copy link
Collaborator

I think that's an appropriate thing to do. The bigger question is do we value the use of rules_perl enough to do that though. I feel like it'd be best to try and build OpenSSL using rules_cc if possible but that's a massive undertaking. Right now rules_perl does not provide windows support which feels like a blocker there. So if that's true, then we'll likely want to maintain the previous way of building OpenSSL when compiling it for the toolchains here

@jsharpe
Copy link
Member Author

jsharpe commented Oct 21, 2021

Building openssl via rules_cc has been done at dropbox but only for linux x86_64. This PR adds support for macOS dropbox/dbx_build_tools#40 but we'd still be missing windows / other platform support.
I think adding in rules_perl is something that we'll need to do anyway eventually as some of the autotools toolchain requires perl to build; I don't think adding support for windows to it should be that big a deal; afterall we just need it to set the PERL MakeVariable for our use, so even if we add a toolchain for windows that doesn't work with all the rules_perl features I think that'll be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

built cmake is missing dependency on openssl
2 participants