Skip to content

Commit

Permalink
Change default Jsonnet port from C++ to Go (#129)
Browse files Browse the repository at this point in the history
As threatened in #113 in mid-2019, change the default Jsonnet tool to
the Go port, leaving the C++ port available for selection via the
"--define" command-line flag to set the "jsonnet_port" build variable
accordingly.
  • Loading branch information
seh authored May 5, 2020
1 parent ce4028c commit 2a2e641
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
7 changes: 3 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,15 @@ jsonnet_go_dependencies()

## Jsonnet Port Selection

By default, Bazel will use [the C++ port](https://github.com/google/jsonnet) of Jsonnet. To use [the Go port](https://github.com/google/go-jsonnet) of Jsonnet instead, invoke Bazel with the `--define jsonnet_port=go` command-line flag. To select the C++ port explicitly, invoke Bazel with the `--define jsonnet_port=cpp` command-line flag.
By default, Bazel will use [the Go port](https://github.com/google/go-jsonnet) of Jsonnet. To use [the C++ port](https://github.com/google/jsonnet) of Jsonnet instead, invoke Bazel with the `--define jsonnet_port=cpp` command-line flag. To select the Go port explicitly, invoke Bazel with the `--define jsonnet_port=go` command-line flag.

_bazel_ Flag | Jsonnet Port
------------ | ------------
(none) | C++
(none) | Go
`--define jsonnet_port=cpp`| C++
`--define jsonnet_port=go` | Go

Note that the primary development focus of the Jsonnet project is now with the Go port. This repository's support for using the C++ port is deprecated, and may be removed in a future release. Before then, its default port will likely change from C++ to Go in the next release.

Note that the primary development focus of the Jsonnet project is now with the Go port. This repository's support for using the C++ port is deprecated, and may be removed in a future release.

<a name="#jsonnet_library"></a>
## jsonnet_library
Expand Down
4 changes: 2 additions & 2 deletions jsonnet/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ config_setting(
alias(
name = "jsonnet_tool",
actual = select({
"//jsonnet:port_go": "@jsonnet_go//cmd/jsonnet",
"//conditions:default": "@jsonnet//cmd:jsonnet",
"//jsonnet:port_cpp": "@jsonnet//cmd:jsonnet",
"//conditions:default": "@jsonnet_go//cmd/jsonnet",
}),
)

0 comments on commit 2a2e641

Please sign in to comment.