Skip to content

Resolve relative symlinks in bootstrap script #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −1
Open

Resolve relative symlinks in bootstrap script #3344

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06fcc19
fix(bootstrap): resolve relative symlinks
mattyclarkson Oct 13, 2025
6026613
fix(bootstrap): report dangling symlinks
mattyclarkson Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion python/private/stage1_bootstrap_template.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,17 @@ else
if [[ ! -L "$stub_filename" ]]; then
break
fi
stub_filename=$(readlink $stub_filename)
stub_filename_target=$(readlink $stub_filename)
if [[ "$stub_filename_target" == /* ]]; then
stub_filename="$stub_filename_target"
else
stub_filename="${stub_filename%/*}/$stub_filename_target"
fi
unset stub_filename_target
if [[ ! -e "$stub_filename" ]]; then
echo >&2 "Unable to find runfiles directory for $1: dangling symlink: $stub_filename"
exit 1
fi
done
echo >&2 "Unable to find runfiles directory for $1"
exit 1
Expand Down