Use buildifier_prebuilt instead of manually fetching Buildifier #1788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadenPete
requested review from
WojciechMazur,
mbland and
simuons
as code owners
jadenPete
force-pushed
the
jpeterson-use-rules-jvm-external-part-0
branch
from
a3ed066 to
91368d5
Compare
It's my goal to remove `dev_deps`, and switching to `buildifier-prebuilt` gets us one step closer to doing that. It should also make CI faster.
jadenPete
force-pushed
the
jpeterson-use-rules-jvm-external-part-0
branch
from
91368d5 to
350db17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first in a series to refactor the ruleset to use
rules_jvm_externalfor fetching all Maven artifacts.It refactors the ruleset to use the
buildifier_prebuiltruleset for downloading Buildifier, as opposed to downloading it manually viahttp_archiveindev_deps_repositories. That'll allow us to deletedev_deps_repositoriesin the next PR. It should also speed up internal development, as Buildifier won't have to be built from scratch and the repositories necessary to build it won't have to be downloaded.Motivation
Please see this PR for more information on this initiative and the motivations behind it:
#1775