Skip to content

Commit

Permalink
Update rules_apple to 2.0.0
Browse files Browse the repository at this point in the history
Update `rules_apple` to https://github.com/bazelbuild/rules_apple/releases/tag/2.0.0:

- Handle bazelbuild/rules_apple@c23720d by adding `cc_info` param to `framework_provider_partial` call.
- Handle bazelbuild/rules_apple@51d6273 by removing `bin_root_path`/`rule_label` param to `debug_symbols_partial` call.
- Handle bazelbuild/rules_apple@a4de222 by removing the `apple_xcframework.framework_type` param.
  • Loading branch information
mattrobmattrob committed Dec 23, 2022
1 parent dfb604d commit 98bf4ab
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
3 changes: 1 addition & 2 deletions rules/framework.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,6 @@ def _bundle_dynamic_framework(ctx, is_extension_safe, avoid_deps):
),
partials.debug_symbols_partial(
actions = actions,
bin_root_path = bin_root_path,
bundle_extension = bundle_extension,
bundle_name = bundle_name,
debug_dependencies = dep_frameworks,
Expand All @@ -700,7 +699,6 @@ def _bundle_dynamic_framework(ctx, is_extension_safe, avoid_deps):
dsym_info_plist_template = apple_mac_toolchain_info.dsym_info_plist_template,
executable_name = executable_name,
platform_prerequisites = platform_prerequisites,
rule_label = label,
),
partials.embedded_bundles_partial(
frameworks = [archive_for_embedding],
Expand All @@ -722,6 +720,7 @@ def _bundle_dynamic_framework(ctx, is_extension_safe, avoid_deps):
binary_artifact = binary_artifact,
bundle_name = bundle_name,
bundle_only = False,
cc_info = link_result.cc_info,
objc_provider = link_result.objc,
rule_label = label,
),
Expand Down
4 changes: 2 additions & 2 deletions rules/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ def rules_ios_dependencies():
_maybe(
github_repo,
name = "build_bazel_rules_apple",
ref = "f99c3cb7e472ecd68b81ea8dab97609a4b75db06",
ref = "c628b0e4b3261b4627bcd4e9f91e75b4e5eb0e1a",
project = "bazelbuild",
repo = "rules_apple",
sha256 = "5e82a98a591efda772a5ee96ed17bcad38338aafeba6055daab04a5d6c13ea50",
sha256 = "495ffc13769b81e401d108a47925885c43f9dfccfbb229d4418d509c6cea14be",
)

_maybe(
Expand Down
1 change: 0 additions & 1 deletion tests/ios/frameworks/dynamic/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ apple_xcframework(
name = "iOSSwiftXCFramework",
bundle_id = "com.google.example",
bundle_name = "c",
framework_type = ["dynamic"],
infoplists = [
"Info.plist",
],
Expand Down

0 comments on commit 98bf4ab

Please sign in to comment.