Skip to content

Commit

Permalink
Turn off remote cache for local dev, cleanup github actions UI clutter (
Browse files Browse the repository at this point in the history
#749)

* Streamline CI config settings

+ Remove clutter from github actions
  • Loading branch information
jerrymarino committed Aug 10, 2023
1 parent 1ae33d8 commit b17f64e
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 40 deletions.
25 changes: 11 additions & 14 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -54,19 +54,17 @@ build:ios_multi_arch_test --ios_minimum_os=10.2
build:ios_multi_arch_test --ios_multi_cpus=i386,x86_64

# - Remote cache configuration
build:remote_cache --bes_backend=grpcs://remote.buildbuddy.io
build:remote_cache --bes_results_url=https://app.buildbuddy.io/invocation/
build:remote_cache --experimental_build_event_upload_strategy=local
build:remote_cache --experimental_remote_cache_compression
build:remote_cache --experimental_remote_merkle_tree_cache
build:remote_cache --modify_execution_info=^(BitcodeSymbolsCopy|BundleApp|BundleTreeApp|DsymDwarf|DsymLipo|GenerateAppleSymbolsFile|ObjcBinarySymbolStrip|CppLink|ObjcLink|ProcessAndSign|SignBinary|SwiftArchive|SwiftStdlibCopy)$=+no-remote,^(BundleResources|ImportedDynamicFrameworkProcessor)$=+no-remote-exec
build:remote_cache --nolegacy_important_outputs
build:remote_cache --noslim_profile
build:remote_cache --remote_cache=grpcs://remote.buildbuddy.io
build:remote_cache --remote_timeout=3600

# Enable remote_cache config by default
build --config=remote_cache
build:ci_with_caches --bes_backend=grpcs://remote.buildbuddy.io
build:ci_with_caches --bes_results_url=https://app.buildbuddy.io/invocation/
build:ci_with_caches --experimental_build_event_upload_strategy=local
build:ci_with_caches --experimental_remote_cache_compression
build:ci_with_caches --experimental_remote_merkle_tree_cache
build:ci_with_caches --modify_execution_info=^(BitcodeSymbolsCopy|BundleApp|BundleTreeApp|DsymDwarf|DsymLipo|GenerateAppleSymbolsFile|ObjcBinarySymbolStrip|CppLink|ObjcLink|ProcessAndSign|SignBinary|SwiftArchive|SwiftStdlibCopy)$=+no-remote,^(BundleResources|ImportedDynamicFrameworkProcessor)$=+no-remote-exec
build:ci_with_caches --nolegacy_important_outputs
build:ci_with_caches --noslim_profile
build:ci_with_caches --remote_cache=grpcs://remote.buildbuddy.io
build:ci_with_caches --remote_timeout=3600
build:ci_with_caches --config=ci

# By default don't upload local results to remote cache, only CI does this.
build --noremote_upload_local_results
Expand All @@ -82,7 +80,6 @@ common:ci --show_progress_rate_limit=15.0
build:ci --progress_report_interval=60
# enable more verbose logging
build:ci --verbose_failures
build:ci --subcommands
# ci setup for tests, tend to be more flaky on github actions
build:ci --jobs=4
# allow extra time for simulators to boot
Expand Down
File renamed without changes.
52 changes: 26 additions & 26 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
runs-on: macos-12
steps:
- uses: actions/checkout@v3
- name: Select Xcode
run: .github/workflows/xcode_select.sh
- name: Preflight Env
run: .github/workflows/preflight_env.sh
- name: Build and Test
run: |
# non-iOS tests
bazelisk test \
--config=ci \
--config=ci_with_caches \
-- \
//... \
-//tests/ios/...
Expand All @@ -36,7 +36,7 @@ jobs:
# iOS tests
bazelisk test \
--config=ci \
--config=ci_with_caches \
--config=ios \
--test_arg=--destination=platform=ios_simulator,id=$SIMULATOR_UDID \
-- \
Expand All @@ -56,21 +56,21 @@ jobs:
runs-on: macos-12
steps:
- uses: actions/checkout@v3
- name: Select Xcode
run: .github/workflows/xcode_select.sh
- name: Preflight Env
run: .github/workflows/preflight_env.sh
- name: Build and Test
run: |
# non-iOS tests
bazelisk test \
--config=ci \
--config=ci_with_caches \
--config=vfs \
-- \
//... \
-//tests/ios/...
# iOS tests
bazelisk test \
--config=ci \
--config=ci_with_caches \
--config=ios \
--config=vfs \
-- \
Expand All @@ -89,13 +89,13 @@ jobs:
USE_BAZEL_VERSION: 5.3.2
steps:
- uses: actions/checkout@v3
- name: Select Xcode
run: .github/workflows/xcode_select.sh
- name: Preflight Env
run: .github/workflows/preflight_env.sh
- name: Build and Test
run: |
# iOS tests
bazelisk build \
--config=ci \
--config=ci_with_caches \
--config=ios \
--config=vfs \
-- \
Expand All @@ -112,12 +112,12 @@ jobs:
runs-on: macos-12
steps:
- uses: actions/checkout@v3
- name: Select Xcode
run: .github/workflows/xcode_select.sh
- name: Preflight Env
run: .github/workflows/preflight_env.sh
- name: Build and Test
run: |
bazelisk build \
--config=ci \
--config=ci_with_caches \
--config=vfs \
--ios_multi_cpus=sim_arm64 \
-- \
Expand All @@ -127,7 +127,7 @@ jobs:
# Misc issues:
# - Fails on a non fat framework for //tests/ios/unit-test/test-imports-app/
bazelisk build \
--config=ci \
--config=ci_with_caches \
--config=ios \
--config=vfs \
--ios_multi_cpus=sim_arm64 \
Expand All @@ -146,8 +146,8 @@ jobs:
runs-on: macos-12
steps:
- uses: actions/checkout@v3
- name: Select Xcode
run: .github/workflows/xcode_select.sh
- name: Preflight Env
run: .github/workflows/preflight_env.sh
# Note: we need to pass the absolute to the Bazel run
- name: buildifier
run: |
Expand All @@ -156,7 +156,7 @@ jobs:
- name: Check docs
run: |
bazelisk run \
--config=ci \
--config=ci_with_caches \
//docs
git diff --exit-code docs
Expand All @@ -165,8 +165,8 @@ jobs:
runs-on: macos-12
steps:
- uses: actions/checkout@v3
- name: Select Xcode 14.2.0
run: .github/workflows/xcode_select.sh
- name: Preflight Env
run: .github/workflows/preflight_env.sh
- name: Run tests
run: ./tests/xcodeproj-tests.sh --run && ./tests/test-tests.sh
- uses: actions/upload-artifact@v2
Expand All @@ -180,12 +180,12 @@ jobs:
runs-on: macos-12
steps:
- uses: actions/checkout@v3
- name: Select Xcode 14.2.0
run: .github/workflows/xcode_select.sh
- name: Preflight Env
run: .github/workflows/preflight_env.sh
- name: Run tests
run: |
bazelisk test \
--config=ci \
--config=ci_with_caches \
--config=ios_lldb_test \
-- \
tests/ios/lldb/app:objc_app_po_test \
Expand All @@ -202,12 +202,12 @@ jobs:
runs-on: macos-12
steps:
- uses: actions/checkout@v3
- name: Select Xcode
run: .github/workflows/xcode_select.sh
- name: Preflight Env
run: .github/workflows/preflight_env.sh
- name: Build App
run: |
bazelisk build \
--config=ci \
--config=ci_with_caches \
--config=ios_multi_arch_test \
-- \
tests/ios/app/App

0 comments on commit b17f64e

Please sign in to comment.