Don't write to home on $PREFLIGHT_ENV

bazel-ios · Aug 10, 2023 · d5fd8c4 · d5fd8c4
1 parent 9d5b062
commit d5fd8c4
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 25 deletions.
diff --git a/.bazelrc b/.bazelrc
@@ -54,17 +54,17 @@ build:ios_multi_arch_test --ios_minimum_os=10.2
 build:ios_multi_arch_test --ios_multi_cpus=i386,x86_64
 
 # - Remote cache configuration
-build:ci_remote_cache --bes_backend=grpcs://remote.buildbuddy.io
-build:ci_remote_cache --bes_results_url=https://app.buildbuddy.io/invocation/
-build:ci_remote_cache --experimental_build_event_upload_strategy=local
-build:ci_remote_cache --experimental_remote_cache_compression
-build:ci_remote_cache --experimental_remote_merkle_tree_cache
-build:ci_remote_cache --modify_execution_info=^(BitcodeSymbolsCopy|BundleApp|BundleTreeApp|DsymDwarf|DsymLipo|GenerateAppleSymbolsFile|ObjcBinarySymbolStrip|CppLink|ObjcLink|ProcessAndSign|SignBinary|SwiftArchive|SwiftStdlibCopy)$=+no-remote,^(BundleResources|ImportedDynamicFrameworkProcessor)$=+no-remote-exec
-build:ci_remote_cache --nolegacy_important_outputs
-build:ci_remote_cache --noslim_profile
-build:ci_remote_cache --remote_cache=grpcs://remote.buildbuddy.io
-build:ci_remote_cache --remote_timeout=3600
-
+build:ci_with_caches --bes_backend=grpcs://remote.buildbuddy.io
+build:ci_with_caches --bes_results_url=https://app.buildbuddy.io/invocation/
+build:ci_with_caches --experimental_build_event_upload_strategy=local
+build:ci_with_caches --experimental_remote_cache_compression
+build:ci_with_caches --experimental_remote_merkle_tree_cache
+build:ci_with_caches --modify_execution_info=^(BitcodeSymbolsCopy|BundleApp|BundleTreeApp|DsymDwarf|DsymLipo|GenerateAppleSymbolsFile|ObjcBinarySymbolStrip|CppLink|ObjcLink|ProcessAndSign|SignBinary|SwiftArchive|SwiftStdlibCopy)$=+no-remote,^(BundleResources|ImportedDynamicFrameworkProcessor)$=+no-remote-exec
+build:ci_with_caches --nolegacy_important_outputs
+build:ci_with_caches --noslim_profile
+build:ci_with_caches --remote_cache=grpcs://remote.buildbuddy.io
+build:ci_with_caches --remote_timeout=3600
+build:ci_with_caches --config=ci
 
 # By default don't upload local results to remote cache, only CI does this.
 build --noremote_upload_local_results

diff --git a/.github/workflows/preflight_env.sh b/.github/workflows/preflight_env.sh
@@ -6,7 +6,3 @@ printenv
 
 sudo xcode-select -p
 sudo xcode-select -s /Applications/Xcode_14.2.app
-
-cat << EOF > $HOME/.bazelrc
-build:ci --config=ci_remote_cache
-EOF
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -23,7 +23,7 @@ jobs:
         run: |
           # non-iOS tests
           bazelisk test \
-            --config=ci \
+            --config=ci_with_caches \
             -- \
             //... \
             -//tests/ios/...
@@ -36,7 +36,7 @@ jobs:
 
           # iOS tests
           bazelisk test \
-            --config=ci \
+            --config=ci_with_caches \
             --config=ios \
             --test_arg=--destination=platform=ios_simulator,id=$SIMULATOR_UDID \
             -- \
@@ -62,15 +62,15 @@ jobs:
         run: |
           # non-iOS tests
           bazelisk test \
-            --config=ci \
+            --config=ci_with_caches \
             --config=vfs \
             -- \
             //... \
             -//tests/ios/...
 
           # iOS tests
           bazelisk test \
-            --config=ci \
+            --config=ci_with_caches \
             --config=ios \
             --config=vfs \
             -- \
@@ -95,7 +95,7 @@ jobs:
         run: |
           # iOS tests
           bazelisk build \
-            --config=ci \
+            --config=ci_with_caches \
             --config=ios \
             --config=vfs \
             -- \
@@ -117,7 +117,7 @@ jobs:
       - name: Build and Test
         run: |
           bazelisk build \
-            --config=ci \
+            --config=ci_with_caches \
             --config=vfs \
             --ios_multi_cpus=sim_arm64  \
             -- \
@@ -127,7 +127,7 @@ jobs:
           # Misc issues:
           #   - Fails on a non fat framework for //tests/ios/unit-test/test-imports-app/
           bazelisk build \
-            --config=ci \
+            --config=ci_with_caches \
             --config=ios \
             --config=vfs \
             --ios_multi_cpus=sim_arm64 \
@@ -156,7 +156,7 @@ jobs:
       - name: Check docs
         run: |
           bazelisk run \
-            --config=ci \
+            --config=ci_with_caches \
             //docs
           git diff --exit-code docs
 
@@ -185,7 +185,7 @@ jobs:
       - name: Run tests
         run: |
           bazelisk test \
-            --config=ci \
+            --config=ci_with_caches \
             --config=ios_lldb_test \
             -- \
             tests/ios/lldb/app:objc_app_po_test \
@@ -207,7 +207,7 @@ jobs:
       - name: Build App
         run: |
           bazelisk build \
-            --config=ci \
+            --config=ci_with_caches \
             --config=ios_multi_arch_test \
             -- \
             tests/ios/app/App