Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rules_apple to 2.0.0 #633

Merged
merged 6 commits into from
Jan 10, 2023
Merged

Update rules_apple to 2.0.0 #633

merged 6 commits into from
Jan 10, 2023

Commits on Dec 22, 2022

  1. Validate extension safety only on dynamic frameworks 

    # Summary
Only validate the dynamic frameworks (those with `apple_common.AppleDynamicFramework`) when calling the `partials.extension_safe_validation_partial` partial. This mimics the `rules_apple` approach more correctly:

https://github.com/bazelbuild/rules_apple/blob/eb5c03a606b103e9f8b72de954103eb00cf127f7/apple/internal/ios_rules.bzl#L1049-L1053
    @mattrobmattrob
    mattrobmattrob committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    4195941 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. Update rules_apple to 2.0.0 

    Update `rules_apple` to https://github.com/bazelbuild/rules_apple/releases/tag/2.0.0:

- Handle bazelbuild/rules_apple@c23720d by adding `cc_info` param to `framework_provider_partial` call.
- Handle bazelbuild/rules_apple@51d6273 by removing `bin_root_path`/`rule_label` param to `debug_symbols_partial` call.
- Handle bazelbuild/rules_apple@a4de222 by removing the `apple_xcframework.framework_type` param.
    @mattrobmattrob
    mattrobmattrob committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    d4717d8 View commit details
    Browse the repository at this point in the history

  2. Update to rules_swift 1.5.0

    @mattrobmattrob
    mattrobmattrob committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    03d7453 View commit details
    Browse the repository at this point in the history

  3. Rename NestedHeaders/ to Nested/ 

    This works around bazelbuild/rules_apple#1797.
    @mattrobmattrob
    mattrobmattrob committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    c997703 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Handle ObjcProvider.module_map removal 

    Handle https://github.com/bazelbuild/rules_apple/pull/1552/files or bazelbuild/rules_apple@5d7d31d by self-identifying the `modulemap` file(s) since the forwarding of them in `ObjcProvider` was removed.
    @mattrobmattrob
    mattrobmattrob committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    4fc8630 View commit details
    Browse the repository at this point in the history

  2. Regen Xcode project

    @mattrobmattrob
    mattrobmattrob committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    d740c4e View commit details
    Browse the repository at this point in the history