Use bazel-ios/rules_apple

[dostrander]

Uses the bazel-ios/rules_apple fork which has updates that need to be upstreamed before we can go back to using bazel's rules_apple

[mattrobmattrob]

Might be useful to get #633 merged first. Not sure how much you're pulling the rules_apple reference forward in this one.

[jerrymarino]

@mattrobmattrob are you planning to push forward 2.0 sometime soon?

I think you are right - there is probably some breaking changes in this sha if we just pull HEAD we might need to roll it back to the current version.

[mattrobmattrob]

@mattrobmattrob are you planning to push forward 2.0 sometime soon?

I think you are right - there is probably some breaking changes in this sha if we just pull HEAD we might need to roll it back to the current version.

Yeah, likely switching back to focus on it tomorrow. Can make it my priority to unblock y'all.

[jerrymarino]

Cool thanks a lot! We can also roll back our fork as well / ensure this commit just advances on the current rules_apple sha in the repo - to give the 2.0 bump a bit more breathing room / time

[jerrymarino]

INFO: From Testing //tests/ios/frameworks/mixed-source/custom-module-map:CustomModuleMapTests:
                          [--launch_options_json_path LAUNCH_OPTIONS_JSON_PATH]
                          [--signing_options_json_path SIGNING_OPTIONS_JSON_PATH]
                          [--test_type TEST_TYPE] [--work_dir WORK_DIR]
                          [--output_dir OUTPUT_DIR]
                          {prepare,test,simulator_test} ...
ios_test_runner.py: error: unrecognized arguments: --product_module_name=CustomModuleMapTests

That looks like a legit failure ☝️

[jerrymarino]

LGTM: @mattrobmattrob once you bump to 2.0.0 we can take care of rebasing the fork for our test sharding fixes

[mattrobmattrob]

LGTM: @mattrobmattrob once you bump to 2.0.0 we can take care of rebasing the fork for our test sharding fixes

FWIW, #633 is ready now. 👍