-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bzlmod #703
Conversation
68d11a5
to
0641bad
Compare
e526722
to
541c0d4
Compare
b67df7e
to
dc5cae9
Compare
541c0d4
to
9f5b83e
Compare
dc5cae9
to
da9a8b3
Compare
9f5b83e
to
00bee92
Compare
47f9d6e
to
31a3539
Compare
00bee92
to
c84bc21
Compare
d4e6afb
to
ba1987c
Compare
c84bc21
to
e80bdab
Compare
e5740af
to
dba6df6
Compare
e80bdab
to
02e02b7
Compare
dba6df6
to
452f68e
Compare
576d108
to
c97dad7
Compare
4ccb5b2
to
154e009
Compare
c97dad7
to
06360f5
Compare
154e009
to
a8109a5
Compare
06360f5
to
7ce7a5f
Compare
7271b3d
to
dfe6561
Compare
1138ba7
to
186c436
Compare
75fe577
to
ca4d59f
Compare
Will be blocked by #773 if that merges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luispadron I think it's time to land this and forward fix. For the rules_apple 3.x update - I will rebase the changes once we land it.
f4d13f5
to
3977cb8
Compare
This commit adds support for bzlmod. See the MODULE.bazel for changes and enable with `--enable_bzlmod`.
3977cb8
to
a3a74ed
Compare
|
||
def _non_module_deps_impl(_): | ||
rules_ios_dependencies( | ||
load_bzlmod_dependencies = False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI - This confused me, because I thought "load_bzlmod_dependencies" means "dependencies that bzlmod needs" rather than "dependencies that bzlmod has already supplied". Just putting this here in case anyone else stumbles across this, and as always, naming is hard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to update it the other day and I felt the same way lol
Happy to change this to something more clear
Adds initial support for bzlmod to rules_ios.
Major changes:
repositories.bzl
to use minimum supported bzlmod versionMODULE.bazel
and required files to enable bzlmod by default in Bazel 6+Required workarounds:
_main
in bzlmod. This doesnt seem to cause any actual issues with the generated project besides the repository being named_main
. Proper fix is to have this use runfiles but I do not have enough context to make that change.Things to follow-up on:
Depends on: #716, #719