Pass datamodels to AppleResourceInfo in _precompiled_apple_resource_bundle #746
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszumski
approved these changes
Jul 27, 2023
jerrymarino
reviewed
Jul 27, 2023
| @@ -199,6 +199,12 @@ def _precompiled_apple_resource_bundle_impl(ctx): | |||
| return [ | |||
| AppleResourceInfo( | |||
| unowned_resources = depset(), | |||
| datamodels = [ | |||
There was a problem hiding this comment.
Is it fair to say this change causes duplicating the data in the action graph or duplicating inputs somehow? Maybe we could move the xcdatamodel to be exclusively fed here or somehow mitigate copying it 2 times - that might cause an issue with upstream rules_apple but better to not have to copy files in general VS clone them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When integrating with
rules_xcodeprojnoticed that after generating an Xcode project the generator wasn't picking up existing.xccurrentversionfiles under.xcdatamodelddirectories due torules_iosnot propagating these in the providers of_precompiled_apple_resource_bundle.Because of this once you launch Xcode (just launching, no other user action needed) it is generating a non-empty
git diffwith.xccurrentversionfiles changed, most likely an Xcode internal logic to try to heal itself and find some.xccurrentversionto load (which could be different than the one you intended to use if you've got multiple version).This PR passes
datamodelstoAppleResourceInfoto fix that.Requires: bazel-ios/rules_apple@8210cec
Without this
rules_applechange we would hit the exception in the commit above:confirmed that the file being copied is exactly the same, so even though there's an overwrite happening when using
shutilit's replacing a file for another file that is the same.