[DNR] #755
Closed
[DNR] #755
+128
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to override stuff. Test rules were impossible to extend and difficult reasoning about how it worked with rules_apple - which led to issues implementing new features like shard by class. Test rules simply accept a `test_suite_factory`. On the default one, which you can override parts if necesary. _The default one could be much generic - but at some point, I expect people to just make their own `test_suite_factory` VS adding too many abstractions to it_ Last: normalize all into a single bundle - otherwise it would duplicate tons of data and be un-useable at scale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.