[Bazel 6.x.x] sdk_dylib at _end_ of the linker invocation #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrymarino
force-pushed
the
jmarino/bazel_6_linker_issue
branch
from
5f6d80f
to
718409c
Compare
Apple's > Xcode 4.x linkers have problems when SDK dylibs are first - Bazel 6.0 broke this due to refactoring. see changes in ( https://github.com/bazelbuild/bazel/blob/283ed362e6ccceb047553c2517a0331afd02db90/tools/osx/crosstool/cc_toolchain_config.bzl#L261 ) So this PR, is adding sdk_dylib to _end_ of the linker invocation to make this work as it did
jerrymarino
force-pushed
the
jmarino/bazel_6_linker_issue
branch
from
718409c
to
36da6cd
Compare
thiagohmcruz
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple's > Xcode 4.x linkers have problems when SDK dylibs are first - Bazel 6.0 broke this due to refactoring. see changes in ( https://github.com/bazelbuild/bazel/blob/283ed362e6ccceb047553c2517a0331afd02db90/tools/osx/crosstool/cc_toolchain_config.bzl#L261 )
So this PR, is adding sdk_dylib to end of the linker invocation to make this work as it did