Make update_in_place opt-in (true by default) #768
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the
codesign
issues being redirected here SwiftUI Previews will crash in Xcode (usingrules_xcodeproj
) withThis happens only in
vendored_xcframeworks
that already provide the slices I need for Apple Silicon so planning to conditionally disable thisupdate_in_place
logic only in "SwiftUI Previews" builds.More generally how are we supposed to handle this
codesign
errors inDebug
builds where aprovisioning_profile
is not set? My suggestion is to allow this conditional behavior while we discuss this, happy to file an issue if needed.