Fix marking of development dependencies #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
luis/fix-changed-dev-dependencies
branch
from
115045b
to
a032924
Compare
The bzlmod PR marked `arm64-to-sim`, `rules_pkg`, and `tart` as development dependencies. There are some repos relying on the versions defined in these so include them in the WORKSAPCE file when using `rules_ios_dependencies`.
luispadron
force-pushed
the
luis/fix-changed-dev-dependencies
branch
from
a032924
to
0904d59
Compare
luispadron
commented
Oct 17, 2023
| @@ -141,13 +143,6 @@ def _rules_ios_bzlmod_dependencies(): | |||
| ], | |||
| ) | |||
|
|
|||
| def _rules_ios_bzlmod_dev_dependencies(): | |||
There was a problem hiding this comment.
The git diff here seems wrong, the real change was moving rules_pkg from _rules_ios_bzlmod_dev_dependencies to _rules_ios_bzlmod_dependencies
justinseanmartin
approved these changes
Oct 17, 2023
jerrymarino
approved these changes
Oct 17, 2023
| "com_github_yonaskolb_xcodegen", | ||
| "tart", | ||
| ) | ||
|
|
||
| non_module_dev_deps = use_extension( |
There was a problem hiding this comment.
We could add a comment here:
Note: these are the deps used in rules_ios testing infra and examples and not for consumers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bzlmod PR marked
arm64-to-sim,rules_pkg, andtartas development dependencies. There are some repos relying on the versions defined in these so include them in the WORKSAPCE file when usingrules_ios_dependencies.Fix #781