-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bzlmod files for first publish #787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay assuming that building everything doesn't require dev dependencies: They will not be available in the BCR test setup which works by creating a synthetic empty module depending on your root module - your module won't be the root module.
Makes sense, so i'll make this more strict to just build |
8623d2b
to
95dfb84
Compare
Noticing some more changes I need to make to |
95dfb84
to
8addeff
Compare
Had to make two changes:
With these changes, I get a green build depending on rules_ios from another bzlmod module: bazel build @rules_ios//rules/...
INFO: Analyzed 67 targets (134 packages loaded, 17858 targets configured).
INFO: Found 67 targets...
INFO: From Linking external/rules_ios~override/rules/hmap/hmaptest:
ld: warning: ignoring duplicate libraries: '-lc++'
INFO: From Linking external/rules_ios~override/rules/hmap/hmaptool:
ld: warning: ignoring duplicate libraries: '-lc++'
INFO: From Linking external/rules_ios~override/rules/hmap/hmapdump:
ld: warning: ignoring duplicate libraries: '-lc++'
INFO: Elapsed time: 28.322s, Critical Path: 7.12s
INFO: 442 processes: 257 internal, 142 darwin-sandbox, 43 local.
INFO: Build completed successfully, 442 total actions |
Feedback from: bazelbuild/bazel-central-registry#1052