Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pkg_resources module not found in CI #804

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

luispadron
Copy link
Collaborator

@luispadron luispadron commented Nov 7, 2023

This script seems to be failing here, this works locally so trying to re-install the module before.

Copy link
Contributor

@jerrymarino jerrymarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does running this with Bazel change the invocation of the script WRT reliability

@luispadron
Copy link
Collaborator Author

@jerrymarino Was hoping we could enforce the pkg_resources module but it looks like thats deprecated in Python 3. I wonder if github updated the runners recently to cause this module not found issue

@luispadron luispadron changed the title Add prepare_sim tool to bazel build Fix pkg_resources module not found in CI Nov 7, 2023
@luispadron
Copy link
Collaborator Author

Looks like adding pip install setuptools fixes the issue

@luispadron luispadron enabled auto-merge (squash) November 7, 2023 19:39
Copy link
Collaborator

@mattrobmattrob mattrobmattrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming there's not some easier built in package to do the work of pkg_resources.

@luispadron luispadron merged commit 1e7b9ea into master Nov 7, 2023
9 checks passed
@luispadron luispadron deleted the luis/fix-build-test-ci-job branch November 7, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants