Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bazel7 sim_arm64 dynamic framework link error, pass dynamic framework info #915

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions rules/import_middleman.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,16 @@ def _file_collector_rule_impl(ctx):
alwayslink = False,
)
for static_library in replaced_static_framework.replaced.values()
] + [
# Bazel7 should specify dynamic library for link
cc_common.create_library_to_link(
actions = ctx.actions,
cc_toolchain = cc_toolchain,
feature_configuration = cc_features,
dynamic_library = dynamic_library,
alwayslink = False,
)
for dynamic_library in replaced_dynamic_framework.values()
]),
),
]),
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading