Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new PR cancel previous PR's workflow #918

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

@mattrobmattrob
Copy link
Collaborator

Have the specific example where you saw this not working?

@gyfelton
Copy link
Contributor Author

@mattrobmattrob While i am waiting for my PR to pass, it got cancelled here: https://github.com/bazel-ios/rules_ios/actions/runs/10905270306/attempts/2
I checked actions list and saw another PR coming in, so I start looking at the github doc and it seems that the new change is what is recommended.
I also test myself by add a new commit on top of this PR. And previous run is cancelled: https://github.com/bazel-ios/rules_ios/pull/918/checks?sha=9c421cdfc3b13537a707a7a9524d21235dff2aa4

i assume can only test whether another PR job will kill previous run or not after merging this change

@mattrobmattrob mattrobmattrob enabled auto-merge (squash) September 17, 2024 21:03
@gyfelton
Copy link
Contributor Author

Note that runners we have are super limited, so new PR just cannot have CI job running until another PR finishes. We are considering to remove support for bazel 6.5.0 in test matrix to help with this. But not sure when to do it

@mattrobmattrob mattrobmattrob merged commit 6c6d621 into master Sep 18, 2024
23 checks passed
@mattrobmattrob mattrobmattrob deleted the fix-ci-job-concurrency branch September 18, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants