Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #2599

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Conversation

Vertexwahn
Copy link
Contributor

@Vertexwahn Vertexwahn commented Aug 14, 2024

@bazel-io
Copy link
Member

Hello @curoky, modules you maintain (catch2) have been updated in this PR. Please review the changes.

@Vertexwahn
Copy link
Contributor Author

Need skip-url-stability-check label.

@Vertexwahn
Copy link
Contributor Author

@meteorcloudy Can you add the skip-url-stability-check label?
@curoky Can you approve?

curoky
curoky previously approved these changes Oct 1, 2024
@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Oct 1, 2024
fmeum
fmeum previously approved these changes Oct 1, 2024
bazel-io
bazel-io previously approved these changes Oct 1, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@bazel-io
Copy link
Member

bazel-io commented Oct 1, 2024

Hello @curoky, modules you maintain (catch2) have been updated in this PR. Please review the changes.

@bazel-io bazel-io dismissed stale reviews from curoky, fmeum, and themself October 1, 2024 15:53

Require module maintainers' approval for newly pushed changes.

@Vertexwahn Vertexwahn requested a review from curoky October 1, 2024 15:56
@Vertexwahn
Copy link
Contributor Author

@curoky Once again please ;)

@Vertexwahn
Copy link
Contributor Author

@curoky I added also Catch 3.7.1

@Vertexwahn Vertexwahn requested a review from fmeum October 1, 2024 16:19
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@meteorcloudy meteorcloudy merged commit 892c1d3 into bazelbuild:main Oct 2, 2024
33 checks passed
asa pushed a commit to asa/bazel-central-registry that referenced this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants