Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rules_antlr 0.5.0.bcr.1 #2650

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mortenmj
Copy link
Contributor

This upstreams the work to add bzlmod support for rules_antlr, done in https://github.com/buildbarn/go-xdr
Support is somewhat minimal, but enough to support the current usecase.

There's no published archive for rules_antlr, requiring override to use an unstable archive. As the project is unmaintained, I don't see that changing.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_antlr) have been updated in this PR. Please review the changes.

@mortenmj mortenmj force-pushed the mmj/rules_antlr branch 2 times, most recently from 2e6e1b8 to ddd994e Compare August 20, 2024 14:26
@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Aug 20, 2024
fmeum
fmeum previously approved these changes Aug 20, 2024
@bazel-io bazel-io dismissed fmeum’s stale review August 21, 2024 06:09

Require module maintainers' approval for newly pushed changes.

@mortenmj mortenmj force-pushed the mmj/rules_antlr branch 3 times, most recently from df30ed9 to f33b211 Compare August 21, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants