Skip to content

Conversation

@dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Oct 15, 2025

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules (cxx.rs) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 1.0.187 of the cxx.rs module to the Bazel Central Registry. The changes are standard for a new version release. However, I've identified an issue in the presubmit.yml file where the build_targets and test_targets are specified using the module's repository name (@cxx.rs//...). For anonymous module tasks in the BCR, targets should be referenced from the root of the module under test, which is //.... I have provided a suggestion to correct this, which will ensure the presubmit checks run as intended.

Comment on lines +12 to +15
build_targets:
- '@cxx.rs//...'
test_targets:
- '@cxx.rs//...'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In presubmit.yml for an anonymous module task, the targets should be referenced relative to the module's root. The correct syntax is //..., not @cxx.rs//.... The @cxx.rs repository name refers to the module when it's a dependency, but in presubmit, the module under test is the main module.

    build_targets:
      - "//..."
    test_targets:
      - "//..."

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@dtolnay dtolnay closed this Oct 18, 2025
@dtolnay dtolnay deleted the cxx.rs-1.0.187 branch October 18, 2025 16:32
@dtolnay
Copy link
Contributor Author

dtolnay commented Oct 18, 2025

Blocked on bazelbuild/rules_rust#3562.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants