Add support for --docker_platform flag #994
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating configs on a Mac (esp. ones with Apple silicon) using a Linux image, the docker daemon raises a warning
The
rbe_config_gen
expects thedocker create
command to return the container ID (which is 64 characters in length). The above warning breaks the contract and therefore will fail the config generation.A possible solution is to add a
--docker_platform
flag torbe_config_gen
so that when it invokesdocker create
, a matching platform can be used to create the container (e.g.rbe_config_gen --docker_platform=linux/amd64
runsdocker create --rm --platform linux/amd64 ...
).Closes #993