Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2 (stable) - February 2020 #10133

Closed
7 of 10 tasks
dslomov opened this issue Oct 30, 2019 · 23 comments
Closed
7 of 10 tasks

Release 2.2 (stable) - February 2020 #10133

dslomov opened this issue Oct 30, 2019 · 23 comments
Assignees
Labels

Comments

@dslomov
Copy link
Contributor

dslomov commented Oct 30, 2019

Status of Bazel 2.2.0

To report a release-blocking bug, please file a bug using the Release blocker label, and cc me.

Task list:

@jin jin pinned this issue Jan 7, 2020
@jmillikin-stripe
Copy link
Contributor

Scheduling note: if possible, I'd love to get #10622 into this release -- it's been delayed a fairly long time on design reviews, and our internal builds are suffering for it.

@dslomov dslomov changed the title Release 2.2 - February 2020 Release 2.2 (stable) - February 2020 Feb 3, 2020
@philwo
Copy link
Member

philwo commented Feb 3, 2020

@meteorcloudy Can we make Bazel 2.2 our first release built on Kokoro? :)

@meteorcloudy
Copy link
Member

meteorcloudy commented Feb 4, 2020

Yes!
It turned out there are more work to be done for migrating to Kokoro. So I think let's not hurry for 2.2.

@philwo
Copy link
Member

philwo commented Feb 12, 2020

@jmillikin-stripe I'm sorry, the PR you wanted to have in Bazel 2.2 still hasn't been merged yet, but I'm already super late with cutting the baseline for Bazel 2.2. The next Bazel release will already be cut on March 1st.

I pinged Jakob, but he said he can't get it done right now, so I have to go ahead and prepare Bazel 2.2 now.

@philwo
Copy link
Member

philwo commented Feb 13, 2020

I'm preparing Bazel 2.2.0 now:

RELEASE_NUMBER=2.2.0
BASELINE_COMMIT=78055efad0917b848078bf8d97b3adfddf91128d
git clone https://github.com/bazelbuild/bazel.git ~/bazel-release-$RELEASE_NUMBER
cd ~/bazel-release-$RELEASE_NUMBER
scripts/release/release.sh create $RELEASE_NUMBER $BASELINE_COMMIT

@gertvdijk
Copy link
Contributor

It's here I guess? ➡️ https://releases.bazel.build/2.2.0/rc1/index.html
🚀

@philwo
Copy link
Member

philwo commented Feb 14, 2020

@gertvdijk Correct. :) I'll send the announcement to bazel-discuss@ now.

@nevion
Copy link

nevion commented Feb 15, 2020

@philwo little bit of a threadjack but I noticed in the rc1 release notes the cuda/opencl file extension support I've been using for ~2 years now and that recently got accepted was reverted
See
250647b
#6578

Is this going to be cut from 2.2 / can you maybe make sure to chase down why it's important to revert those changes and the right thing to do over all?

@gertvdijk
Copy link
Contributor

FWIW, 2.2.0rc1 works like a charm here as drop-in replacement for 2.1.0 (tested @ linux x86_64 via Bazelisk on some internal repos).

@philwo
Copy link
Member

philwo commented Feb 27, 2020

@gertvdijk Let's push it then :D

I haven't heard about any release blockers.

Edit: I haven't finished the release notes yet, will do that tomorrow morning and then push the release. 2.2.0 will be identical to 2.2.0rc1 unless I hear anything by then.

@philwo
Copy link
Member

philwo commented Mar 3, 2020

Release 2.2.0 has been pushed, release notes on our blog to follow.

@vbatts
Copy link

vbatts commented Mar 3, 2020 via email

vbatts added a commit to vbatts/copr-build-bazel that referenced this issue Mar 3, 2020
vbatts added a commit to vbatts/copr-build-bazel that referenced this issue Mar 3, 2020
@vbatts
Copy link

vbatts commented Mar 3, 2020

none of the aarch64 builds succeeded

@philwo
Copy link
Member

philwo commented Mar 3, 2020

Looks like this is the error on aarch64:

bazel-out/aarch64-opt/bin/external/bazel_tools/tools/jdk/include/jni.h:45:10: fatal error: jni_md.h: No such file or directory
   45 | #include "jni_md.h"

If someone can repro and send a PR to fix it, I can look into doing a patch release. I won't have time to do it myself this week unfortunately.

@katre
Copy link
Member

katre commented Mar 3, 2020

We should also file this so I can track it for the next release.

@source-creator
Copy link

@philwo Hi, were you able to do a patch?

I also get this exact error.

My Java details:

$  java -version ; javac -version
openjdk version "1.8.0_212"
OpenJDK Runtime Environment (build 1.8.0_212-8u212-b01-1+rpi1-b01)
OpenJDK Client VM (build 25.212-b01, mixed mode)
javac 1.8.0_212

I have confirmed that jni_md.h does not exist in the JDK include directory, and upon further investigation I saw:

this is done by intent. These compat symlinks were wrong in openjdk-7.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760301

@davido
Copy link
Contributor

davido commented Mar 30, 2020

@vbatts I still cannot install 2.2.0 on Fedora 31:

  $ sudo dnf install bazel
Copr repo for bazel owned by vbatts   
=============================================================
 Package                  Arch   Version            Repository                           Size
=============================================================
 bazel                    x86_64 1.2.1-1.fc31       copr:copr.fedorainfracloud.org:vbatts:bazel

@source-creator
Copy link

I am also still unable to build 2.2.0 on ARM.
I managed to build 2.1.1 last night on ARM.

@vbatts
Copy link

vbatts commented Mar 30, 2020

@vbatts I still cannot install 2.2.0 on Fedora 31:

  $ sudo dnf install bazel
Copr repo for bazel owned by vbatts   
=============================================================
 Package                  Arch   Version            Repository                           Size
=============================================================
 bazel                    x86_64 1.2.1-1.fc31       copr:copr.fedorainfracloud.org:vbatts:bazel

dnf install -y --allowerasing bazel2

@davido
Copy link
Contributor

davido commented Mar 30, 2020

dnf dnf install -y --allowerasing bazel2

Thanks! Should the documentation be updated: [1]?

 dnf copr enable vbatts/bazel
 dnf install bazel

[1] https://docs.bazel.build/versions/master/install-redhat.html

@philwo
Copy link
Member

philwo commented Mar 31, 2020

@source-creator Unfortunately not yet. If anyone has a working patch that makes the build work on ARM, I'm happy to review it and get it in.

@laurentlb laurentlb unpinned this issue Apr 7, 2020
jiridanek added a commit to jiridanek/bazel that referenced this issue May 13, 2020
Per discussion at bazelbuild#10133,
Bazel 2.x is packaged as bazel2 on Red Hat.
jiridanek added a commit to jiridanek/bazel that referenced this issue May 13, 2020
Per discussion at bazelbuild#10133,
Bazel 2.x is packaged as bazel2, and 3.x as bazel3 on Red Hat.
bazel-io pushed a commit that referenced this issue May 15, 2020
Per discussion at #10133,
Bazel 2.x is packaged as bazel2, and 3.x as bazel3 on Red Hat.

CC @vbatts

Closes #11377.

PiperOrigin-RevId: 311701886
@limdor
Copy link
Contributor

limdor commented Jul 20, 2020

@philwo is there a reason why this issue is still opened or just forgotten?

@philwo
Copy link
Member

philwo commented Jul 20, 2020

@limdor Just forgotten to close it, sorry.

@philwo philwo closed this as completed Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

12 participants