-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more Unicode bugs #24182
base: master
Are you sure you want to change the base?
Fix more Unicode bugs #24182
Conversation
d539093
to
b378d1f
Compare
b378d1f
to
db728d4
Compare
@fmeum Mind rebasing before I review? |
@tjgq Thanks for the review, it helped me find and fix more issues. I noticed that there are a bunch of |
I'd prefer a separate PR, thanks! |
@fmeum it looks like there's an issue with .netrc parsing? (see failed tests) |
Should be fixed now |
67fbb4e
to
60bacc5
Compare
@meteorcloudy Compiling a
The raw bytes of the file name are |
That didn't help :-( |
38b4907
to
c2226bd
Compare
I have given up on getting |
c2226bd
to
8670006
Compare
@tjgq Rebased onto master. |
@bazel-io fork 8.0.0 |
unused_input_list
handling of non-ASCII characters in file names.legacy_utf8
parameter ofrepository_ctx.file
toFalse
and make it a no-op. With the previous default, any non-ASCII characters would be written out as double encoded UTF-8, which is not a useful choice.repository_ctx.template
to operate on raw bytes for consistency withrepository_ctx.read
and to fix substitution with non-ASCII keys/values.UTF_8
closer to their usage site to clarify why they are correct./showIncludes
and.d
files)