Filter spawn strategies by execution platform #24265
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements part of the Execution Platform Scoped Spawn Strategies proposal.
It adds a new flag
--allowed_strategies_by_exec_platform
which permits filtering spawn strategies for spawns execution platform.Example
For an action with mnemonic
FOO
configured for the host platform (@platforms//host:host
), it will resolveworker,sandboxed,local
as it's spawn strategy candidates.remote
was eliminated as a candidate (not in allow list for platform).--spawn_strategy
was preserved.For an action with mnemonic
BAR
configured for the host platform (@platforms//host:host
), it will resolvesandboxed
as it's spawn strategy candidate.remote
was eliminated as a candidate (not in allow list for platform).sandboxed
as the final candidate.For an action with mnemonic
BAR
configured for the remote platform (//:remote_platform
), it will resolveremote
as it's spawn strategy candidate.sandboxed
was eliminated as a candidate (not in allow list for platform).remote
as the final candidate.If no spawn strategy candidate remains after filtering, the standard error will be logged.
TODO
CoverageReportActionBuilder.CoverageReportAction
action uses spawn machinery but lacks an execution platform, leading to a precondition check failure. Being resolved in Give builtin actions a platform #23231