Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with non-Latin-1 Unicode characters on Windows #24270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 11, 2024

CI runners have been updated in bazelbuild/continuous-integration@bd27193 to a Windows version that supports the approach taken in 7bb8d2b to start the JVM with UTF-8 as the system encoding.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Nov 11, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 11, 2024

@bazel-io fork 8.0.0

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 11, 2024
@iancha1992
Copy link
Member

@fmeum could you please resolve the conflicts? Thanks

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 11, 2024

@iancha1992 This is conflicting due to the rollback of the other Unicode commit, I'll rebase it when that one has been rolled forward.

@fmeum fmeum marked this pull request as draft November 11, 2024 21:57
@fmeum fmeum marked this pull request as ready for review November 15, 2024 17:28
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Nov 15, 2024
CI runners have been updated in bazelbuild/continuous-integration@bd27193 to a Windows version that supports the approach taken in 7bb8d2b to start the JVM with UTF-8 as the system encoding.
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 15, 2024

@meteorcloudy Rebased onto master with the reland.

@Wyverald Wyverald removed the awaiting-review PR is awaiting review from an assigned reviewer label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants