Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let genquery honor --consistent_labels #24326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Let genquery honor --consistent_labels #24326

wants to merge 1 commit into from
+29 −3

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 14, 2024 •
edited
Loading

Fixes #24325

@fmeum fmeum requested a review from lberki as a code owner November 14, 2024 12:24
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Nov 14, 2024
@fmeum fmeum requested review from Wyverald and removed request for lberki November 14, 2024 12:24
@fmeum fmeum mentioned this pull request Nov 14, 2024
Open
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 14, 2024

@bazel-io fork 8.0.0

@bazel-io bazel-io mentioned this pull request Nov 14, 2024
Open
@tpasternak
Copy link
Contributor

Please correct the referenced issue

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 14, 2024

Please correct the referenced issue

Done!

@tpasternak
Copy link
Contributor

Yes, I can confirm the PR fixes the bug (at least in my project). Thank you @fmeum for such a fact reaction!

@iancha1992 iancha1992 added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Nov 14, 2024
@zhengwei143
Copy link
Contributor

Thanks @fmeum !

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhengwei143 zhengwei143 zhengwei143 approved these changes

@Wyverald Wyverald Awaiting requested review from Wyverald

Assignees
No one assigned
Labels
awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

genquery ignores --consistent_labels
5 participants
@fmeum @tpasternak @zhengwei143 @meteorcloudy @iancha1992