Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make genquery work in external repos #24328

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 14, 2024

Previously, some parts of the query implementation would evaluate labels relative to the main repo in all cases.

fmeum added a commit to fmeum/bazel that referenced this pull request Nov 14, 2024
Some `get*` methods worked with apparent repo names, others didn't, which is a hurdle to contributions in this area (as observed while working on bazelbuild#24328).
@fmeum fmeum requested a review from Wyverald November 14, 2024 13:13
@fmeum fmeum marked this pull request as ready for review November 14, 2024 13:13
@fmeum fmeum requested a review from lberki as a code owner November 14, 2024 13:13
@fmeum fmeum removed the request for review from lberki November 14, 2024 13:13
@github-actions github-actions bot added team-Performance Issues for Performance teams awaiting-review PR is awaiting review from an assigned reviewer labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Performance Issues for Performance teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant